diff --git a/app/frontend/src/components/CV/Skill.tsx b/app/frontend/src/components/CV/Skill.tsx index c6ed3ae..496df55 100644 --- a/app/frontend/src/components/CV/Skill.tsx +++ b/app/frontend/src/components/CV/Skill.tsx @@ -1,8 +1,8 @@ import React from "react"; +import PageBreakAvoid from "../common/PageBreakAvoid"; import { Spacer } from "../common/Spacer"; import { Paragraph } from "../common/Text"; -import PageBreakAvoid from "../common/PageBreakAvoid"; type SkillProps = { title: string; diff --git a/app/server/internal/config/config.go b/app/server/internal/config/config.go index bd8d75d..cb2eea0 100644 --- a/app/server/internal/config/config.go +++ b/app/server/internal/config/config.go @@ -7,10 +7,9 @@ import ( "os" "time" + "go.c3c.cz/cv/app/server/internal/version" "go.uber.org/zap" "go.uber.org/zap/zapcore" - - "go.c3c.cz/cv/app/server/internal/version" ) type FrontendConfigDef struct { diff --git a/app/server/internal/httpserver/httphandler.go b/app/server/internal/httpserver/httphandler.go index a90c410..e2297ae 100644 --- a/app/server/internal/httpserver/httphandler.go +++ b/app/server/internal/httpserver/httphandler.go @@ -14,10 +14,9 @@ import ( "strings" "time" - "go.uber.org/zap" - "go.c3c.cz/cv/app/server/internal/files" "go.c3c.cz/cv/app/server/internal/version" + "go.uber.org/zap" ) type handler struct { @@ -67,7 +66,6 @@ func (h *handler) serveFile(w http.ResponseWriter, r *http.Request, modtime time gw.Reset(io.Discard) } err = gw.Close() - if err != nil { h.logger.Warn("Could not close gzip writer", zap.Error(err)) return diff --git a/app/server/internal/httpserver/httpserver.go b/app/server/internal/httpserver/httpserver.go index 8dabe8e..866f378 100644 --- a/app/server/internal/httpserver/httpserver.go +++ b/app/server/internal/httpserver/httpserver.go @@ -10,9 +10,8 @@ import ( "net/http" "time" - "go.uber.org/zap" - "go.c3c.cz/cv/app/server/internal/files" + "go.uber.org/zap" ) func init() { diff --git a/app/server/main.go b/app/server/main.go index 4f16538..51c98f2 100644 --- a/app/server/main.go +++ b/app/server/main.go @@ -8,12 +8,11 @@ import ( "os/signal" "syscall" - "go.uber.org/zap" - "go.c3c.cz/cv/app/server/internal/config" "go.c3c.cz/cv/app/server/internal/httpserver" "go.c3c.cz/cv/app/server/internal/pprofserver" "go.c3c.cz/cv/app/server/internal/version" + "go.uber.org/zap" ) func main() { @@ -33,7 +32,6 @@ func main() { var err error logger, err = config.LoggerConfig.Build() - if err != nil { fmt.Println(notice) fmt.Println(version.CommitTime.Format("Committed at 2006/01/02 15:04:05 MST")) diff --git a/flake.nix b/flake.nix index d5444f3..fd61689 100644 --- a/flake.nix +++ b/flake.nix @@ -73,6 +73,19 @@ ]; commands = [ + { + # Override golangci-lint for vscode, because the extension incorrectly assumes usage of global binaries is preferred + name = "golangci-lint"; + command = '' + CMD=''${1:-} + if [[ "$CMD" == "run" ]]; then + shift + ${pkgs.golangci-lint}/bin/golangci-lint run --config ${nix.lib.golangci-config-file} $@ + else + ${pkgs.golangci-lint}/bin/golangci-lint $@ + fi + ''; + } { name = "lint"; help = "run linters"; @@ -87,7 +100,7 @@ help = "format & fix found issues"; command = '' ${nix.lib.cd_root} - nix fmt . + nix fmt ./*.nix ${pkgs.golangci-lint}/bin/golangci-lint run --sort-results --out-format tab --config ${nix.lib.golangci-config-file} --fix --issues-exit-code 0 ./... npm --prefix app/frontend run fix '';