Update golangci config

.gitignore

@@ -1,4 +1,5 @@
 .env
 .envrc
 .direnv
+.devenv
 result

.golangci.yml

@@ -1,78 +1,123 @@
-linters-settings:
-  errcheck:
-    check-type-assertions: true
-  gci:
-    sections:
-      - standard
-      - default
-      - prefix(go.yrps.dev)
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
-    disabled-checks:
-      - hugeParam
-      - paramTypeCombine
-      - sloppyReassign
-  govet:
-    enable-all: true
-    settings:
-      shadow:
-        strict: true
-  nolintlint:
-    require-explanation: true
-    require-specific: true
-  sloglint:
-    no-global: "all"
-    context: "scope"
-  stylecheck:
-    checks:
-      - all
-      - -ST1000
-  wsl:
-    allow-cuddle-declarations: true
+version: "2"
+
+run:
+  timeout: 3m
+  relative-path-mode: gitroot
 
 linters:
-  disable-all: true
   enable:
     - bidichk
     - bodyclose
+    - canonicalheader
     - copyloopvar
     - errcheck
     - errorlint
-    - exportloopref
     - exhaustive
-    - gci
+    - forbidigo
     - gocheckcompilerdirectives
+    - gochecksumtype
     - goconst
     - gocritic
-    - gofumpt
     - gosec
-    - gosimple
     - govet
     - ineffassign
+    - makezero
+    - mirror
     - misspell
+    - nakedret
+    - nilnil
     - noctx
     - nolintlint
+    - nosprintfhostport
+    - perfsprint
     - prealloc
     - predeclared
-    - protogetter
     - sloglint
+    - spancheck
     - staticcheck
-    - stylecheck
+    - unconvert
     - unconvert
     - unparam
     - unused
     - whitespace
     - usestdlibvars
-    - wsl
+    - wastedassign
+    - whitespace
+    - wsl_v5
+  settings:
+    errcheck:
+      check-type-assertions: true
+    forbidigo:
+      analyze-types: true
+    gocritic:
+      disabled-checks:
+        - hugeParam
+        - paramTypeCombine
+        - sloppyReassign
+      enabled-tags:
+        - diagnostic
+        - experimental
+        - opinionated
+        - performance
+        - style
+    govet:
+      enable:
+        - shadow
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+    sloglint:
+      attr-only: true
+      no-global: all
+      context: scope
+      static-msg: true
+      key-naming-case: snake
+      forbidden-keys:
+        - time
+        - level
+        - msg
+        - source
+    staticcheck:
+      checks:
+        - all
+        - -ST1000
+    wsl_v5:
+      disable:
+        - decl
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+
+formatters:
+  enable:
+    - gci
+    - gofumpt
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(go.yrps.dev)
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
-  exclude-use-default: false
-  exclude:
-    - Error return value of .*\.Body\.Close. is not checked
+
+output:
+  sort-order:
+    - file
+  show-stats: false

eslint.config.mjs

@@ -0,0 +1,151 @@
+import jseslint from "@eslint/js";
+import eslintPluginImportX from "eslint-plugin-import-x";
+import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
+import eslintPluginReact from "eslint-plugin-react";
+import eslintPluginReactHooks from "eslint-plugin-react-hooks";
+import eslintPluginReactRefresh from "eslint-plugin-react-refresh";
+import eslintPluginFormatjs from "eslint-plugin-formatjs";
+import tseslint from "typescript-eslint";
+
+// This config is provided through nix environment.
+// Config is meant to be injected through devshell env variable and "cp" command in .envrc to copy it in the proper path
+
+// Install dependencies: npm i -D @eslint/js@9 eslint-plugin-import-x@4 eslint-import-resolver-typescript@3 eslint-plugin-prettier@5 eslint-config-prettier@9 eslint-plugin-react@7 eslint-plugin-react-hooks@5 eslint-plugin-react-refresh@0.4 eslint-plugin-formatjs@5 typescript-eslint@8
+export default tseslint.config(
+  {
+    ignores: [
+      "build/",
+      "dist/",
+      "tsconfig.json",
+      "tsconfig.*.json",
+      "eslint.config.mjs",
+    ],
+  },
+  jseslint.configs.recommended,
+  ...tseslint.configs.recommendedTypeChecked,
+  eslintPluginImportX.flatConfigs.recommended,
+  eslintPluginImportX.flatConfigs.typescript,
+  eslintPluginReact.configs.flat.recommended,
+  eslintPluginPrettierRecommended,
+  {
+    languageOptions: {
+      parserOptions: {
+        tsconfigRootDir: import.meta.dirname,
+        project: "./tsconfig.json",
+      },
+    },
+    settings: {
+      react: {
+        version: "detect",
+      },
+      "import-x/resolver": {
+        typescript: true,
+        node: true,
+      },
+    },
+    plugins: {
+      "react-hooks": eslintPluginReactHooks,
+      "react-refresh": eslintPluginReactRefresh,
+      formatjs: eslintPluginFormatjs,
+    },
+    rules: {
+      curly: ["error"],
+      "no-console": ["warn"],
+      "no-constant-condition": [
+        "error",
+        {
+          checkLoops: "allExceptWhileTrue",
+        },
+      ],
+
+      // Typescript
+      // Some non typescript rules must be disabled as they can report incorrect errors
+      "default-param-last": "off",
+      "@typescript-eslint/default-param-last": "error",
+      "dot-notation": "off",
+      "@typescript-eslint/dot-notation": [
+        "error",
+        {
+          allowKeywords: true,
+        },
+      ],
+      "@typescript-eslint/naming-convention": [
+        "error",
+        {
+          selector: ["function", "import"],
+          format: ["camelCase", "PascalCase"],
+        },
+        {
+          selector: ["variable"],
+          format: ["camelCase", "PascalCase", "UPPER_CASE"],
+        },
+        {
+          selector: ["enum", "typeLike"],
+          format: ["PascalCase"],
+        },
+      ],
+      "@typescript-eslint/no-unused-vars": [
+        "warn",
+        {
+          args: "after-used",
+          caughtErrors: "all",
+          caughtErrorsIgnorePattern: "^_$",
+        },
+      ],
+      "no-use-before-define": "off",
+      "@typescript-eslint/no-use-before-define": "error",
+      "@typescript-eslint/no-misused-promises": [
+        "error",
+        {
+          checksVoidReturn: {
+            attributes: false,
+          },
+        },
+      ],
+      "no-shadow": "off",
+      "@typescript-eslint/no-shadow": "error",
+      "no-loop-func": "off",
+      "@typescript-eslint/no-loop-func": "error",
+      "no-useless-constructor": "off",
+      "@typescript-eslint/no-useless-constructor": "error",
+      "no-return-await": "off",
+      "@typescript-eslint/return-await": "error",
+      "@typescript-eslint/prefer-promise-reject-errors": ["off"],
+
+      // Import
+      "import-x/no-extraneous-dependencies": [
+        "error",
+        {
+          devDependencies: true,
+        },
+      ],
+      // Some issues with react import, no time to debug
+      "import-x/default": ["off"],
+
+      "prettier/prettier": "warn",
+
+      // React
+      "react-hooks/exhaustive-deps": "error",
+      "react-refresh/only-export-components": "warn",
+      "react/jsx-no-duplicate-props": [
+        "error",
+        {
+          ignoreCase: false,
+        },
+      ],
+
+      "react/prop-types": "off",
+      "react/react-in-jsx-scope": "off",
+
+      // FormaJS/INTL
+      "formatjs/enforce-default-message": "error",
+      "formatjs/enforce-id": [
+        "error",
+        {
+          idInterpolationPattern: "[sha1:contenthash:base64:6]",
+        },
+      ],
+      "formatjs/no-id": "off",
+    },
+  }
+);

flake.lock

@@ -1,32 +1,195 @@
 {
   "nodes": {
-    "devshell": {
+    "cachix": {
       "inputs": {
+        "devenv": [
+          "devenv"
+        ],
+        "flake-compat": [
+          "devenv",
+          "flake-compat"
+        ],
+        "git-hooks": [
+          "devenv",
+          "git-hooks"
+        ],
+        "nixpkgs": [
+          "devenv",
+          "nixpkgs"
+        ]
+      },
+      "locked": {
+        "lastModified": 1760971495,
+        "narHash": "sha256-IwnNtbNVrlZIHh7h4Wz6VP0Furxg9Hh0ycighvL5cZc=",
+        "owner": "cachix",
+        "repo": "cachix",
+        "rev": "c5bfd933d1033672f51a863c47303fc0e093c2d2",
+        "type": "github"
+      },
+      "original": {
+        "owner": "cachix",
+        "ref": "latest",
+        "repo": "cachix",
+        "type": "github"
+      }
+    },
+    "devenv": {
+      "inputs": {
+        "cachix": "cachix",
+        "flake-compat": "flake-compat",
+        "flake-parts": "flake-parts",
+        "git-hooks": "git-hooks",
+        "nix": "nix",
         "nixpkgs": [
           "nixpkgs"
         ]
       },
       "locked": {
-        "lastModified": 1722113426,
-        "narHash": "sha256-Yo/3loq572A8Su6aY5GP56knpuKYRvM2a1meP9oJZCw=",
-        "owner": "numtide",
-        "repo": "devshell",
-        "rev": "67cce7359e4cd3c45296fb4aaf6a19e2a9c757ae",
+        "lastModified": 1764927628,
+        "narHash": "sha256-AH2H5O9i7k3oarg3MooAnQtZxo44qxrUTUuvGOy/OEc=",
+        "owner": "cachix",
+        "repo": "devenv",
+        "rev": "247d7027f91368054fb0eefbd755a73d42b66fee",
         "type": "github"
       },
       "original": {
-        "owner": "numtide",
-        "repo": "devshell",
+        "owner": "cachix",
+        "repo": "devenv",
+        "type": "github"
+      }
+    },
+    "flake-compat": {
+      "flake": false,
+      "locked": {
+        "lastModified": 1761588595,
+        "narHash": "sha256-XKUZz9zewJNUj46b4AJdiRZJAvSZ0Dqj2BNfXvFlJC4=",
+        "owner": "edolstra",
+        "repo": "flake-compat",
+        "rev": "f387cd2afec9419c8ee37694406ca490c3f34ee5",
+        "type": "github"
+      },
+      "original": {
+        "owner": "edolstra",
+        "repo": "flake-compat",
+        "type": "github"
+      }
+    },
+    "flake-parts": {
+      "inputs": {
+        "nixpkgs-lib": [
+          "devenv",
+          "nixpkgs"
+        ]
+      },
+      "locked": {
+        "lastModified": 1760948891,
+        "narHash": "sha256-TmWcdiUUaWk8J4lpjzu4gCGxWY6/Ok7mOK4fIFfBuU4=",
+        "owner": "hercules-ci",
+        "repo": "flake-parts",
+        "rev": "864599284fc7c0ba6357ed89ed5e2cd5040f0c04",
+        "type": "github"
+      },
+      "original": {
+        "owner": "hercules-ci",
+        "repo": "flake-parts",
+        "type": "github"
+      }
+    },
+    "git-hooks": {
+      "inputs": {
+        "flake-compat": [
+          "devenv",
+          "flake-compat"
+        ],
+        "gitignore": "gitignore",
+        "nixpkgs": [
+          "devenv",
+          "nixpkgs"
+        ]
+      },
+      "locked": {
+        "lastModified": 1760663237,
+        "narHash": "sha256-BflA6U4AM1bzuRMR8QqzPXqh8sWVCNDzOdsxXEguJIc=",
+        "owner": "cachix",
+        "repo": "git-hooks.nix",
+        "rev": "ca5b894d3e3e151ffc1db040b6ce4dcc75d31c37",
+        "type": "github"
+      },
+      "original": {
+        "owner": "cachix",
+        "repo": "git-hooks.nix",
+        "type": "github"
+      }
+    },
+    "gitignore": {
+      "inputs": {
+        "nixpkgs": [
+          "devenv",
+          "git-hooks",
+          "nixpkgs"
+        ]
+      },
+      "locked": {
+        "lastModified": 1709087332,
+        "narHash": "sha256-HG2cCnktfHsKV0s4XW83gU3F57gaTljL9KNSuG6bnQs=",
+        "owner": "hercules-ci",
+        "repo": "gitignore.nix",
+        "rev": "637db329424fd7e46cf4185293b9cc8c88c95394",
+        "type": "github"
+      },
+      "original": {
+        "owner": "hercules-ci",
+        "repo": "gitignore.nix",
+        "type": "github"
+      }
+    },
+    "nix": {
+      "inputs": {
+        "flake-compat": [
+          "devenv",
+          "flake-compat"
+        ],
+        "flake-parts": [
+          "devenv",
+          "flake-parts"
+        ],
+        "git-hooks-nix": [
+          "devenv",
+          "git-hooks"
+        ],
+        "nixpkgs": [
+          "devenv",
+          "nixpkgs"
+        ],
+        "nixpkgs-23-11": [
+          "devenv"
+        ],
+        "nixpkgs-regression": [
+          "devenv"
+        ]
+      },
+      "locked": {
+        "lastModified": 1761648602,
+        "narHash": "sha256-H97KSB/luq/aGobKRuHahOvT1r7C03BgB6D5HBZsbN8=",
+        "owner": "cachix",
+        "repo": "nix",
+        "rev": "3e5644da6830ef65f0a2f7ec22830c46285bfff6",
+        "type": "github"
+      },
+      "original": {
+        "owner": "cachix",
+        "ref": "devenv-2.30.6",
+        "repo": "nix",
         "type": "github"
       }
     },
     "nixpkgs": {
       "locked": {
-        "lastModified": 1727872001,
-        "narHash": "sha256-nZNSePIWw526864XBqsrWU1dbo4Ei8iJXpNHCubui28=",
+        "lastModified": 1764947035,
+        "narHash": "sha256-EYHSjVM4Ox4lvCXUMiKKs2vETUSL5mx+J2FfutM7T9w=",
         "owner": "nixos",
         "repo": "nixpkgs",
-        "rev": "e46dc3b8343f627532ba881965b053d3bbec4235",
+        "rev": "a672be65651c80d3f592a89b3945466584a22069",
         "type": "github"
       },
       "original": {
@@ -38,7 +201,7 @@
     },
     "root": {
       "inputs": {
-        "devshell": "devshell",
+        "devenv": "devenv",
         "nixpkgs": "nixpkgs"
       }
     }

flake.nix

@@ -3,8 +3,8 @@
 
   inputs = {
     nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable";
-    devshell = {
-      url = "github:numtide/devshell";
+    devenv = {
+      url = "github:cachix/devenv";
       inputs.nixpkgs.follows = "nixpkgs";
     };
   };
@@ -13,8 +13,9 @@
     {
       self,
       nixpkgs,
-      devshell,
-    }:
+      devenv,
+      ...
+    }@inputs:
     let
       systems = nixpkgs.lib.genAttrs [
         "x86_64-linux"
@@ -32,7 +33,9 @@
             function (
               import nixpkgs {
                 inherit system;
-                overlays = [ devshell.overlays.default ];
+                overlays = [
+                  devenv.overlays.default
+                ];
                 config.allowUnfreePredicate = (pkg: builtins.elem (nixpkgs.lib.getName pkg) [ "terraform" ]);
               }
             )
@@ -40,37 +43,80 @@
 
         golangci-config-file = ./.golangci.yml;
 
-        cd_root = "cd $PRJ_ROOT;";
+        eslint-config-file = ./eslint.config.mjs;
 
-        control4_env = self.lib.forAllSystems (
+        cd_root = "cd $DEVENV_ROOT;";
+
+        mdtohtml-src = self.lib.forAllSystems (
+          pkgs: pkgs.fetchFromGitHub {
+            owner = "gomarkdown";
+            repo = "mdtohtml";
+            rev = "d773061d1585e9a85aded292f65459b2cb8b2131";
+            sha256 = "sha256-GzYiiLL0yjGK70haRjoXT1QmvAjl+N/Z8H0EBhVOhRY=";
+          }
+        );
+
+        control4-env = self.lib.forAllSystems (
           pkgs:
           pkgs.buildEnv {
             name = "control4_env";
-            paths = [
-              pkgs.lua5_1
-              pkgs.lua51Packages.busted
-              pkgs.stylua
-              pkgs.nodejs_22
+            paths = with pkgs; [
+              lua5_1
+              lua51Packages.busted
+              stylua
+              nodejs_22
+              (pkgs.buildGoModule {
+                name = "mdtohtml";
+                CGO_ENABLED = 0;
+                src = self.lib.mdtohtml-src.${pkgs.system};
+                subPackages = [ "." ];
+                ldflags = [ "-s" "-w" ];
+                vendorHash = "sha256-HzHwB0XoVjmqucqyDn44NlIG2ASPzZOKv0POiOyBxrY=";
+              })
             ];
           }
         );
+
+        mkDevenvShell = devenv.lib.mkShell;
       };
 
       formatter = self.lib.forAllSystems (pkgs: pkgs.nixfmt-rfc-style);
 
+      packages = self.lib.forAllSystems (pkgs: {
+        devenv-up = self.devShells.${pkgs.system}.default.config.procfileScript;
+        devenv-test = self.devShells.${pkgs.system}.default.config.test;
+      });
+
       devShells = self.lib.forAllSystems (pkgs: {
-        default = pkgs.devshell.mkShell {
-          name = "c3c-nix";
-
-          packages = [ pkgs.nix-tree ];
-
-          commands = [
+        default = self.lib.mkDevenvShell {
+          inherit inputs pkgs;
+          modules = [
             {
-              name = "fix";
-              command = ''
-                ${self.lib.cd_root}
-                nix fmt .
-              '';
+              scripts = {
+                menu = {
+                  description = "Print this menu";
+                  exec = ''
+                    echo "Commands:"
+                    echo -n '${builtins.toJSON (builtins.mapAttrs (s: value: value.description) self.devShells.${pkgs.system}.default.config.scripts)}' | \
+                    ${pkgs.jq}/bin/jq -r 'to_entries | map("  \(.key)\n" + "    - \(if .value == "" then "no description provided" else .value end)") | "" + .[]'
+                  '';
+                };
+
+                fix = {
+                  exec = ''
+                    ${self.lib.cd_root}
+                    nix fmt ./*.nix
+                  '';
+                };
+
+                github-push = {
+                  description = "Push current branch to github, lazy workaround for automated mirror. TODO: Automate";
+                  exec = ''
+                    b=$(git rev-parse --abbrev-ref HEAD)
+                    git push git@github.com:Sharsie/nix.git "$b":"$b"
+                  '';
+                };
+              };
             }
           ];
         };